Remove votesTokenMasterCopyContract from interfaces #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
commented
May 5, 2024
src/types/strategyAzorius.ts
Outdated
There was a problem hiding this comment.
Slowly killing these interfaces heheheheh
src/types/fractal.ts
Outdated
There was a problem hiding this comment.
Slowly killing these interfaces heheheheh
adamgall
commented
May 5, 2024
| @@ -31,7 +31,7 @@ export type NetworkConfig = { | |||
| fractalAzoriusMasterCopy: string; | |||
| fractalModuleMasterCopy: string; | |||
| fractalRegistry: string; | |||
| votesERC20MasterCopy: string; | |||
| votesERC20MasterCopy: Address; | |||
There was a problem hiding this comment.
Also sneaking this update into this PR. See all of the networkconfig file changes as well.
Honestly though, these changes aren't even necessary at this stage in the refactoring I don't think.
After removing the @fractal-framework/fractal-contracts imports from the whole codebase except for the contract addresses in the various network config files, then I'll go through and fix the types of all contracts to be Address.
This was referenced May 5, 2024
DarksightKellar
approved these changes
May 6, 2024
adamgall
force-pushed
the
remove-ethers-from-useapproval
branch
from
01d4bd7 to
718fd50
Compare
adamgall
force-pushed
the
remove-votestokenmastercopycontract-from-interfaces
branch
from
7557352 to
e00e034
Compare
…nd FractalContracts interface, fix all typescript issues
adamgall
force-pushed
the
remove-votestokenmastercopycontract-from-interfaces
branch
from
e00e034 to
f0f4b26
Compare
adamgall
added a commit
that referenced
this pull request
May 8, 2024
…ntract-from-interfaces Remove votesTokenMasterCopyContract from interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and merge #1642 first.